Skip to content

Support for global RPGLINT configuration path#435

Open
francois-rpg wants to merge 25 commits into
codefori:mainfrom
francois-rpg:main
Open

Support for global RPGLINT configuration path#435
francois-rpg wants to merge 25 commits into
codefori:mainfrom
francois-rpg:main

Conversation

@francois-rpg

@francois-rpg francois-rpg commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Changes

This PR adds support for specifying a global RPGLINT config path using the new setting rpgle.globalLintConfigPath.
If checked, linter configs for libraries will be based on IFS's /etc/vscode/rpglint.json.
This helps enforce company-wide lint standards.
Exclude libraries also added, to enable user to add libraries they don't want linted, e.g. browsing prod libraries' source.

Checklist

  • [Y] have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in the README
  • for feature PRs: PR only includes one feature enhancement.

This is my first pull request to anything on github, ever. Please let me know if and where I went wrong so I contribute cleanly in the future.

@worksofliam worksofliam self-assigned this Jul 30, 2025
@worksofliam worksofliam self-requested a review August 12, 2025 18:43
worksofliam
worksofliam requested changes Aug 14, 2025
View reviewed changes

@worksofliam worksofliam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is a great start! I am going to need some files removed from this PR:

  • package-extension.yml - please don't add any new actions to this PR. Perhaps in a separate one if this is something you want to see.
  • Please remove all .vsix files. We don't want to check them into the repo.

Thanks! Then I will go in for a second review 😄

@worksofliam worksofliam removed their assignment Aug 14, 2025
@francois-rpg

francois-rpg commented Aug 14, 2025

Copy link
Copy Markdown
Author

Requested changes completed.
Thank you for the feedback.

worksofliam
worksofliam requested changes Mar 20, 2026
View reviewed changes

@worksofliam worksofliam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this has token so long to get to.

  1. Can you please fix the formatting in your new changes? They don't match the indentation of the rest of the file.
  2. Can you fix the conflicts

Thanks!

@SanjulaGanepola

SanjulaGanepola commented May 5, 2026

Copy link
Copy Markdown
Member

I think we should standardize with Code for IBM i and make use of the /home/<user>/.vscode directory to store this configuration file much like the settings.json and profiles.json. We can also use the ConfigFile APIs. What do you think?

@francois-rpg

francois-rpg commented May 5, 2026

Copy link
Copy Markdown
Author

I think we should standardize with Code for IBM i and make use of the /home/<user>/.vscode directory to store this configuration file much like the settings.json and profiles.json. We can also use the ConfigFile APIs. What do you think?

That is a good idea. I've been thinking about this change, should there also be a switch on/off?
If you're browsing your main repo with old programs you don't necessarily want linting.
Thoughts?

@SanjulaGanepola

SanjulaGanepola commented May 5, 2026

Copy link
Copy Markdown
Member

Also I made a typo in my original comment. I meant to type /etc/vscode instead of /home/<user>/.vscode as this is a shared global config directory in Code4i. As long as you use the ConfigFile API, it will automatically use this directory.

should there also be a switch on/off?

Great point actually. I'm wondering what would be the best way to support this though. What where you thinking?

@francois-rpg francois-rpg marked this pull request as draft May 18, 2026 20:37
@francois-rpg francois-rpg mentioned this pull request Jun 12, 2026
Open
@francois-rpg

francois-rpg commented Jun 12, 2026

Copy link
Copy Markdown
Author

I have made final changes on my side, making it easier to configure the global files (Not uploaded yet, need testing first).
There is an issue with Mapepire at the moment.
I logged the below and will await a fix before finishing off this PR.
#532

@francois-rpg

francois-rpg commented Jun 12, 2026

Copy link
Copy Markdown
Author

Also I made a typo in my original comment. I meant to type /etc/vscode instead of /home/<user>/.vscode as this is a shared global config directory in Code4i. As long as you use the ConfigFile API, it will automatically use this directory.

should there also be a switch on/off?

Great point actually. I'm wondering what would be the best way to support this though. What where you thinking?

Hi Sanjula,
I hope you're well.

Do you think switching to this method would solve for the existing Mapepire issue? Or should I rather wait for them to fix the one I logged?

francois-rpg and others added 2 commits June 14, 2026 09:26
@francois-rpg
Applied suggested changes
0de072c 
Changed global path to use IFS.
Brought in line with issue PR fixing lint creation.
@francois-rpg
Merge branch 'main' into main
bd1a4df
@francois-rpg francois-rpg marked this pull request as ready for review June 14, 2026 07:51
@francois-rpg

francois-rpg commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@worksofliam @SanjulaGanepola
Changed config path to IFS.
Tested successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@worksofliam worksofliam worksofliam requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francois-rpg @SanjulaGanepola @worksofliam